On 08/25/2011 09:10 AM, Greg KH wrote:
On Tue, Aug 23, 2011 at 06:05:27PM +0200, David Herrmann wrote:
From: Jason Stubbs<jasonbstubbs@xxxxxxxxx>
On some samsung laptops the brightness regulation works slightly different.
All SABI commands except for set_brightness work as expected. The behaviour
of set_brightness is as follows:
- Setting a new brightness will only step one level toward the new brightness
level. For example, setting a level of 5 when the current level is 2 will
result in a brightness level of 3.
- A spurious KEY_BRIGHTNESS_UP or KEY_BRIGHTNESS_DOWN event is also generated
along with the change in brightness.
- Neither of the above two issues occur when changing from/to brightness level 0.
This patch adds detection and a non-intrusive workaround for the above issues.
Signed-off-by: David Herrmann<dh.herrmann@xxxxxxxxxxxxxx>
---
Hi
This patch is originally from Jason Stubbs. See here:
http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=platform-samsung_laptop-add-support-for-samsung-nc210-nc110.patch;hb=HEAD
I just wanted to ask whether there is some work going on here? My laptop model
needs this fix and I reviewed and tested it and it works fine. It would be nice
to see this upstream.
I have a different patch from Jason that should fix this properly, I'll
send it to Matthew later today.
If you're talking about the min/max calculations patch, that fixes a
separate issue to this patch. Both patches touch set_brightness()
though, which is probably where the confusion came from.
The version of the patch in git doesn't apply on top of the min/max
calcs patch that you've added to the gregkh-2.6 tree, but I've
previously posted a version that does. You can find it at
https://lkml.org/lkml/2011/5/13/150 or I can post it again.
Regards,
Jason Stubbs
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
