Il 15/07/2011 00:05, Mattia Dongili ha scritto:
I recently uploaded the first part (new features excluded) of my v2
patches at http://www.absence.it/vaio-acpi/source/patches/patchset-v2/
to help you and receive new feedbacks.
Still no feedbacks...
still not much time. what I noticed so far:
- patches are 14 instead of 25, any reason?
Because writing patches is time consuming. The first 14 patches include
code cleaning/reorganization and improvements that can be merged
immediately (if they look fine now), while the new features are a bit
more problematic. Please, just review these 14 patches at the moment.
- still stopping handlers evaluation if the magi SncSupported string is
not present
I do believe it's a good thing to have it. Do you prefer to drop the
while patch #14 or just to change that check?
- the function naming in patch 5 looks ok.
Do you wish to include the change from
struct sony_nc_handles {
u16 cap[0x10];
struct device_attribute devattr;
};
static struct sony_nc_handles *handles;
to
struct sony_nc_handles_list {
u16 cap[0x10];
struct device_attribute devattr;
};
static struct sony_nc_handles_list *handles;
as well?
Once again, post the patches here with proper description, it's easier
for everyone to review and comment the changes.
I'm still waiting for a few replies [1], I'd rather avoid spending time
to send the patches twice. As soon as everything look fine (we are
close) I will send the patches again.
[1]
http://www.spinics.net/lists/platform-driver-x86/msg02214.html
http://www.spinics.net/lists/platform-driver-x86/msg02213.html
(and possibly
http://www.spinics.net/lists/platform-driver-x86/msg02216.html)
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
