On Wed, Jun 22, 2011 at 04:07:38PM +0800, Ike Panhc wrote: > -static void ideapad_sync_rfk_state(struct acpi_device *adevice) > +static void ideapad_sync_rfk_state(struct ideapad_private *priv) > { This should be a separate patch. > -static void __devexit ideapad_unregister_rfkill(struct acpi_device *adevice, > - int dev) > +static void ideapad_unregister_rfkill(struct acpi_device *adevice, int dev) This also seems unrelated. > +static int ideapad_backlight_get_brightness(struct backlight_device *blightdev) > +{ > + unsigned long now; > + > + if (read_ec_data(ideapad_handle, 0x12, &now)) > + return -EAGAIN; Description says you're using commands on the VPC2004 device, but it looks like you're just poking the embedded controller? Are you sure the EC offsets are stable? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html