Re: [PATCH 8/25] sony-laptop: sony_nc_notify rewritten and improved

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 06/06/2011 00:38, Mattia Dongili ha scritto:
On Sat, Jun 04, 2011 at 01:26:28PM +0200, Marco Chiappero wrote:
Il 04/06/2011 10:43, Mattia Dongili ha scritto:
when sony_call_snc_handle(handle, 0x200,&result) fails above you will
be reporting -1 via the acpi bus. The old code restored the event and
reported the raw number instead.

You are right, does the following sony_nc_notify modification look
fine to you?

/* hotkey event, a key has been pressed, retrieve it */
value = sony_nc_hotkeys_decode(handle);
if (value>  0) /* known event */
	sony_laptop_report_input_event(value);
else /* restore the original event */
	value = event;

it's a bit out of context but I guess it should work.

Two things I'd like to ask:
1) can I remove any acpi bus notification from this patch?
2) if so, do you prefer sony_nc_hotkeys_decode to forward decoded keys to the input core directly instead of returning the decoded value back to sony_nc_notify? I'm not sure about what you meant with "out of context", is the above point #2?

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux