Re: [PATCH 4/25] sony-laptop: new SNC setup and cleanup functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 13/06/2011 16:10, Marco Chiappero ha scritto:
Il 13/06/2011 15:42, Mattia Dongili ha scritto:

I'd rather not have
this check here.

Avoiding this check here seems a logical error to me: it's
basically the
entry point (and the first thing to look at when calling the setup
method SN00), maybe revealing info about the device and the action
to be
taken about this device, I can't see why we'd better skip this step,
that doesn't hurt, just because at the moment almost every notebook
won't fail.

the string never changes and there seems to be no logic associated
to it
in the DSDT.

Well, maybe. Or maybe not. Every year lots of new models are
launched, and every model comes with it... why should they bring a

Apparently not. Vaio Y doesn't have that string hardcoded in the DSDT.

Interesting, may I see such DSDT file?

I've seen the DSDT file, and I can say that almost surely (well, I'd say surely) this model comes with the same string, even though it's hardcoded in some hw register instead (the first bytes of CIM more precisely). My idea hasn't changed, I strongly suggest to maintain this check, if the string changes we will have the chance to immediately determine what changed, otherwise it won't harm.

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux