Hi Matthew,
æ äï2011-05-31 æ 14:20 +0800ïLee, Chun-Yi æåï
> Fix a bitwise bug that was found by Joern Heissler, it must be OR
> but not AND when we query current device state.
>
> Acked-by: Joern Heissler <linux-acpi@xxxxxxxxxxxxxxxxx>
> Cc: Carlos Corbacho <carlos@xxxxxxxxxxxxxxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: Dmitry Torokhov <dtor@xxxxxxx>
> Cc: Corentin Chary <corentincj@xxxxxxxxxx>
> Cc: Thomas Renninger <trenn@xxxxxxx>
> Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxxxx>
> ---
> drivers/platform/x86/acer-wmi.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 005417b..7d4675a 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1156,9 +1156,9 @@ static acpi_status wmid3_set_device_status(u32 value, u16 device)
> struct wmid3_gds_input_param params = {
> .function_num = 0x1,
> .hotkey_number = 0x01,
> - .devices = ACER_WMID3_GDS_WIRELESS &
> - ACER_WMID3_GDS_THREEG &
> - ACER_WMID3_GDS_WIMAX &
> + .devices = ACER_WMID3_GDS_WIRELESS |
> + ACER_WMID3_GDS_THREEG |
> + ACER_WMID3_GDS_WIMAX |
> ACER_WMID3_GDS_BLUETOOTH,
> };
> struct acpi_buffer input = {
Sorry for my mistake!!
There have a bitwise bug in commit
6d88ff0f8ef3529f68233d3963b2a7e07f8e4f69 in kernel 3.0-rc1.
Please kindly help to review and merge this patch to 3.0-rc2 to fix it.
Thank's a lot!
Joey Lee
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
