Re: [PATCH v3] thinkpad-acpi: Improve hardware volume controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 14, 2011 at 11:34:25AM -0400, Andy Lutomirski wrote:

> It turns out that we can ask ACPI for one of three behaviors
> directly.  They are "latch" (the default), "none" (no automatic
> control), and "toggle" (mute unmutes when muted).  So we let the
> user control the mode through sysfs, and we don't generate KEY_MUTE
> in any mode other than "none".
> 
> As an added bonus, we fix an old bug: the hardware mute control
> doesn't generate an ALSA change notification on newer ThinkPads.

Which of these modes make sense for userspace? "none" sounds like it'd 
be fine, except that the LED wouldn't work on new machines. So should we 
just be setting "toggle" in all cases? The optimal situation would be 
that we delete the OSI blacklist at the same time as we add this code.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux