Re: [PATCH -rc1] msi-laptop: fix config-dependent build error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



æ äï2011-03-30 æ 15:20 -0700ïRandy Dunlap æåï
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> The msi-laptop driver uses input_*() and sparse_keymap_*() interfaces.
> It should depend on the INPUT subsystem being present and select
> INPUT_SPARSEKMAP so that those interfaces are present.
> 
> ERROR: "input_free_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_register_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_setup" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_allocate_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_report_event" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "input_unregister_device" [drivers/platform/x86/msi-laptop.ko] undefined!
> ERROR: "sparse_keymap_free" [drivers/platform/x86/msi-laptop.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: "Lee, Chun-Yi" <jlee@xxxxxxxxxx>
> ---
>  drivers/platform/x86/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- lnx-2639-rc1.orig/drivers/platform/x86/Kconfig
> +++ lnx-2639-rc1/drivers/platform/x86/Kconfig
> @@ -187,7 +187,8 @@ config MSI_LAPTOP
>  	depends on ACPI
>  	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on RFKILL
> -	depends on SERIO_I8042
> +	depends on INPUT && SERIO_I8042
> +	select INPUT_SPARSEKMAP
>  	---help---
>  	  This is a driver for laptops built by MSI (MICRO-STAR
>  	  INTERNATIONAL):
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thank's, it's good to me!

Acked-by: "Lee, Chun-Yi" <jlee@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux