On Tue, Mar 15, 2011 at 8:06 AM, Dan Carpenter <error27@xxxxxxxxx> wrote: > "err" needs to be signed for the error handling to work. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index 5b779a9..a038595 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -946,7 +946,8 @@ static int read_brightness_max(struct asus_wmi *asus) > Âstatic int read_brightness(struct backlight_device *bd) > Â{ > Â Â Â Âstruct asus_wmi *asus = bl_get_data(bd); > - Â Â Â u32 retval, err; > + Â Â Â u32 retval; > + Â Â Â int err; > > Â Â Â Âerr = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval); Hm, Thanks, Acked-by: Corentin Chary <corentin.chary@xxxxxxxxx> -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html