On Fri, Feb 25, 2011 at 07:52:11AM +0100, Corentin Chary wrote: > On Fri, Feb 25, 2011 at 6:19 AM, Keng-Yu Lin <keng-yu.lin@xxxxxxxxxxxxx> wrote: > > Signed-off-by: Keng-Yu Lin <keng-yu.lin@xxxxxxxxxxxxx> > > --- > > drivers/platform/x86/eeepc-wmi.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > https://bugs.freedesktop.org/show_bug.cgi?id=31333 > > > > diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c > > index d399775..da00cbc 100644 > > --- a/drivers/platform/x86/eeepc-wmi.c > > +++ b/drivers/platform/x86/eeepc-wmi.c > > @@ -113,7 +113,7 @@ static const struct key_entry eeepc_wmi_keymap[] = { > > { KE_KEY, 0x32, { KEY_MUTE } }, > > { KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */ > > { KE_KEY, 0x5d, { KEY_WLAN } }, > > - { KE_KEY, 0x6b, { KEY_F13 } }, /* Disable Touchpad */ > > + { KE_KEY, 0x6b, { KEY_F21 } }, /* Disable Touchpad */ > > { KE_KEY, 0x82, { KEY_CAMERA } }, > > { KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } }, > > { KE_KEY, 0x88, { KEY_WLAN } }, > > Hum, I'm not very comfortable with this patch now that we got > KEY_TOUCHPAD_TOGGLE. > I know, it doesn't work with current Xorg, but if we continue to > workaround that, it'll never be fixed. > > Dmitry, Matthew, any advice ? I believe that the kernel should use KEY_TOUCHPAD_TOGGLE and userspace should use udev's key re-mapping facilities while X is unable to process keycodes above 255 to adjust to the keycode du jour. If all kernel drivers were to use KEY_TOUCHPAD_TOGGLE then remapping would be much easier (the utility would simply check capabilities for KEY_TOUCHPAD_TOGGLE and do the remap). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
