On Tue, Feb 08, 2011 at 09:08:00AM -0500, Alan Cox wrote: > On Tue, 8 Feb 2011 13:52:28 +0000 > Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > > On Tue, Feb 08, 2011 at 10:45:35AM +0000, Alan Cox wrote: > > > On Mon, 7 Feb 2011 19:58:43 +0000 > > > Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > > > > > > hwmon includes support for exposing the instantaneous current draw. > > > > hwmon includes support for triggering events if a parameter crosses a Not explicitly, really. Sure, one can write a driver which triggers such an event, but afaik there is only one hwmon driver doing that right now, and doing so is not part of the hwmon infrastructure. > > > > threshold. I still don't see why this isn't an hwmon driver, perhaps > > > > with a small platform driver for the more estoric bits of the setup. > > > > > > The hwmon maintainer says its not. Explicitly so. Been there, had that > > > discussion a while ago (in fact we had it as well in December if you > > > remember and I pointed you at the hwmon list discussion > > > > The hwmon maintainer says that it's not an hwmon driver, not that it > > shouldn't be an hwmon driver. > > That's not how I interpret it, but he's Cc'd so I'll let him speak for > himself, failing that I'll stuff it in arch/x86/platform/mrst I guess Seems to me there is some hair splitting going on here. Core element of hwmon drivers is that there are reported temperatures, voltages, current, power, humidity, etc. I don't see any of those here. All I see is various current limits. Those are secondary attributes from hwmon perspective. So I don't really see how this can be made a hwmon driver. Anyway, didn't you have this discussion before ? Does this all have to be repeated over and over again ? I agree with everything Alan has said in the previous exchange last December. Repeating it won't change anything. Guenter -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
