Re: [PATCH] intel_mid_powerbtn: add power button driver for Medfield platform (#3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 02, 2011 at 10:17:45AM +0000, Alan Cox wrote:
> On Sun, 30 Jan 2011 12:39:50 -0800
> Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> 
> > On Thu, Jan 27, 2011 at 01:52:13PM +0000, Alan Cox wrote:
> > > From: Hong Liu <hong.liu@xxxxxxxxx>
> > > 
> > > The power button is connected to MSIC on Medfield, we will get two
> > > interrupts from IOAPIC when pressing or releasing the power button.
> > > 
> > > Signed-off-by: Hong Liu <hong.liu@xxxxxxxxx>
> > > [Minor fixes as noted by Dmitry]
> > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > 
> > Acked-by: Dmitry Torokhov <dtor@xxxxxxx>
> > 
> > Input parts look good to me but you might want to fold in the following
> > patch.
> 
> Ok I wouldn't move the module_init/exit around like that but no big deal
> 8)

Yeah, I can't myself decide which style I like better :)

Well, anyway, aside from MODULE_ALIAS() anything else can be cut from
that patch so I'll leave it to Matthew to decide what he likes best.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux