Re: [PATCH 1/2] eeepc-wmi: add additional hotkeys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 11, 2010 at 3:25 PM, Chris Bagwell <chris@xxxxxxxxxxxxxx> wrote:
> On Mon, Oct 11, 2010 at 1:26 AM, Corentin Chary
> <corentin.chary@xxxxxxxxx> wrote:
>> On Mon, Oct 11, 2010 at 3:48 AM, Â<chris@xxxxxxxxxxxxxx> wrote:
>>> From: Chris Bagwell <chris@xxxxxxxxxxxxxx>
>>>
>>> Added 4 hotkeys using same keymap values as eeepc-latop.
>>> These are mousepad toggle, resolution change, screen off,
>>> and task manager. ÂThese were tested on 1005PE and are the
>>> Fn-F3, F4, F7, and F9, respectively.
>>>
>>> Also, added a new hot key for power toggles (Fn-Space on 1005PE)
>>> and is meant to drive cpufv interface from userspace.
>>>
>>> Finally, added several keys to be ignored that are being emitted
>>> but do not mapped to any useful or documented hotkeys. ÂThis is
>>> purely cosmetic to prevent uknown key reports on console/log files.
>>> These keys are reported on 1005PE's.
>>
>> What are exactly these keys ? Since they are probably some obscure Fn+ combo,
>> and they are probably used on another model, I'm not sure we should hide them.
>
> They are Fn-1, 2, s, d, f, and e. ÂI can't really guess what 1 and 2
> are for but I assume sdfe are arrow keys or something similar on
> larger models?
>
> I debated on if to add ignores since surely some model uses them but I
> settled on someone else can modify current file instead of adding new
> lines once they are driven to add their laptop specific keys.
>
>>
>> I'm still not happy with F13 for "disable touchpad" but I did the same
>> for other laptops,
>> and we don't have a key for that ATM.
>
> And user land doesn't seem very supported of this concept at the
> moment as well. ÂI've tried some xinput stuff on touchpad tied to F13
> but no luck so far. ÂIt does have a property to disable touchpad but
> I've not had time to fully debug yet. ÂI'm trying to stay away fo
> synclient since thats end-of-lifed.
>
>>
>> Otherwise, looks good.
>
> Thanks. ÂBTW, please let me know specifically if you'd like the ignore
> keys removed and I'll re-send a patch. ÂI don't have enough info to be
> able to map them though.

I'd remove them, and wait for someone to complain that he has garbage
in dmesg or unmapped keys.

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux