On Thu, 23 Sep 2010 14:53:01 -0700 Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 23 Sep 2010 23:49:29 +0200 > Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > > > They're optional. If not present or sane, we should use the CPU > > defaults. > > > > Signed-off-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> > > --- > > drivers/platform/x86/intel_ips.c | 23 +++++++++++++++++++++++ > > 1 files changed, 23 insertions(+), 0 deletions(-) > > Note this patch is necessary but not sufficient. At least on one of my > test platforms, I see really bad looking chipset power values from the > i915 driver. That will trigger spurious "power exceeded" messages and > unnecessarily limit your GPU performance. Working on a fix now. Already sent this fix to Chris for inclusion, but here it is for reference and testing in this thread. -- Jesse Barnes, Intel Open Source Technology Center diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 9d67b48..c74e4e8 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1787,9 +1787,9 @@ unsigned long i915_chipset_val(struct drm_i915_private *dev_priv) } } - div_u64(diff, diff1); + diff = div_u64(diff, diff1); ret = ((m * diff) + c); - div_u64(ret, 10); + ret = div_u64(ret, 10); dev_priv->last_count1 = total_count; dev_priv->last_time1 = now; @@ -1858,7 +1858,7 @@ void i915_update_gfx_val(struct drm_i915_private *dev_priv) /* More magic constants... */ diff = diff * 1181; - div_u64(diff, diffms * 10); + diff = div_u64(diff, diffms * 10); dev_priv->gfx_power = diff; } -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
