Hi Axel, On Tue, Jul 06, 2010 at 02:46:58PM +0800, Axel Lin wrote: > In current implementation, acpi_pcc_write_sset return 1 > if write is successful, 0 if write is failed. > But all the callers consider acpi_pcc_write_sset return 0 > if write is successful and return negative if write is failed. > Yes, I think most of the times we see AE_* outside of drivers/acpi/acpica it is an error; we should be using standard eoro codes instead. > This patch changes the implementation of acpi_pcc_write_sset to > return 0 if write is successful, -1 if write is failed. Why not use something better than -1, maybe -EIO, and the propagate that return code up the stack? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
