Re: [PATCH] classmate-laptop: should check for NULL as retval for rfkill_alloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 09, 2010 at 09:46:17PM +0200, Johannes Berg wrote:
> On Wed, 2010-06-09 at 16:39 -0300, Thadeu Lima de Souza Cascardo wrote:
> 
> > +	/*
> > +	 * If RFKILL is disabled, rfkill_alloc will return ERR_PTR(-ENODEV).
> > +	 * This is OK, however, since all other uses of the device will not
> > +	 * derefence it.
> > +	 */
> > +	if (!ipml->rf) {
> 
> the ! shouldn't be there
> 
> johannes
> 

Sorry for that. The else case is unneeded too. Removed in the next
patch.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux