Hello, I am resending the patch with corrections. With these corrections, patch[4/4] is also changed. I will resend all 4 patches once again --Sreedhara -----Original Message----- From: Matthew Garrett [mailto:mjg59@xxxxxxxxxxxxx] Sent: Friday, May 28, 2010 7:17 PM To: Ds, Sreedhara Cc: platform-driver-x86@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; Alan Cox Subject: Re: [Patch 2/4] intel scu ipc On Fri, May 28, 2010 at 02:10:51PM +0530, Ds, Sreedhara wrote: > From cfe6eb1f2ea12732f03d4edee85c50ba713a9d36 Mon Sep 17 00:00:00 2001 > From: Sreedhara DS <sreedhara.ds@xxxxxxxxx> > Date: Fri, 28 May 2010 13:55:44 +0530 > Subject: [PATCH] changes to work on both moorestown and medfield > new pci id added for medfiled > return type of ipc_data_readl chnaged from u8 u32 This sounds like a separate bugfix that should be in a different patch. > - u8 cbuf[IPC_WWBUF_SIZE] = { '\0' }; > + u8 cbuf[IPC_WWBUF_SIZE] = { }; Why this change? > - for (nc = 0; nc < count; nc++) { > + for (nc = 0; nc < count; nc++, offset += 3) { > cbuf[offset] = addr[nc]; > cbuf[offset + 1] = addr[nc] >> 8; > if (id != IPC_CMD_PCNTRL_R) > @@ -201,33 +202,44 @@ static int pwr_reg_rdwr(u16 *addr, u8 *data, u32 count, u32 op, u32 id) > cbuf[offset + 3] = data[nc + 1]; > offset += 1; > } > - offset += 3; Again, what does this have to do with the patch description? > /* Workaround: values are read as 0 without memcpy_fromio */ > - memcpy_fromio(cbuf, ipcdev.ipc_base + IPC_READ_BUFFER, 16); > - if (platform == 1) { > + memcpy_fromio(cbuf, ipcdev.ipc_base + 0x90, 16); > + if (platform == PLATFORM_LANGWELL) { You've replaced one constant with a define, and replaced another define with a constant. That seems a little odd. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
