Hi Mattia,
Great, agree with yours comments and following the new patch.
thanks.
--
Regards,
+--------------------------------------------+
Jorge Pereira,
Blog: http://blog.jorgepereira.com.br/
+--------------------------------------------+
On Mon, May 17, 2010 at 7:19 PM, Mattia Dongili <malattia@xxxxxxxx> wrote:
> Hi Jorge
>
> On Sun, May 16, 2010 at 03:36:52AM -0300, Jorge Pereira wrote:
>> Hi!
>>
>> Recently i bought the sony laptop model 'VPCEB15FB' and this model
>> has Three buttons top of keyboard[1] that don't work until then.
>> added support to all three keys at the driver sony-laptop.c and sonypi.h
>
> Thanks for the patch, it's fundamentally ok but to be honest I'm not too
> convinced about the naming. I'm not sure how "dedicated" the Web will
> be after you pressed the DEDICATED_WEB button. :)
> Also, you seem to have patched an old version of the driver, please
> make sure the patch applies on current code.
>
> See a couple of comments below.
>
> ...
>> From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001
>> From: Jorge Pereira <jpereiran@xxxxxxxxx>
>> Date: Fri, 14 May 2010 18:18:19 -0300
>> Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series.
>>
>> ---
>
> Please also Sign-off the patch in your commit log.
>
> ...
>> + 58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */
>> + 59, /* 73 SONYPI_EVENT_DEDICATED_WEB */
>> + 60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */
>
> Can't these just be SONYPY_EVENT_ASSIST_PRESSED,
> SONYPI_EVENT_WEB_PRESSED and SONYPI_EVENT_VAIO_PRESSED?
> If necessary you can describe what they were originally inteded to in
> the commit message.
>
> Thanks!
> --
> mattia
> :wq!
>
From 5b8ef2e688b64427afb82243a80af8822e063112 Mon Sep 17 00:00:00 2001
From: Jorge Pereira <jpereiran@xxxxxxxxx>
Date: Tue, 18 May 2010 03:56:04 -0300
Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series.
---
drivers/platform/x86/sony-laptop.c | 12 ++++++++++++
include/linux/sonypi.h | 3 +++
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 1387c5f..3580ca4 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -235,6 +235,9 @@ static int sony_laptop_input_index[] = {
57, /* 70 SONYPI_EVENT_VOLUME_DEC_PRESSED */
-1, /* 71 SONYPI_EVENT_BRIGHTNESS_PRESSED */
58, /* 72 SONYPI_EVENT_MEDIA_PRESSED */
+ 59, /* 73 SONYPI_EVENT_ASSIST_PRESSED */
+ 60, /* 74 SONYPI_EVENT_WEB_PRESSED */
+ 61, /* 75 SONYPI_EVENT_VAIO_PRESSED */
};
static int sony_laptop_input_keycode_map[] = {
@@ -297,6 +300,9 @@ static int sony_laptop_input_keycode_map[] = {
KEY_VOLUMEUP, /* 56 SONYPI_EVENT_VOLUME_INC_PRESSED */
KEY_VOLUMEDOWN, /* 57 SONYPI_EVENT_VOLUME_DEC_PRESSED */
KEY_MEDIA, /* 58 SONYPI_EVENT_MEDIA_PRESSED */
+ KEY_HELP, /* 59 SONYPI_EVENT_ASSIST_PRESSED */
+ KEY_HOMEPAGE, /* 60 SONYPI_EVENT_WEB_PRESSED */
+ KEY_SHOP, /* 61 SONYPI_EVENT_VAIO_PRESSED */
};
/* release buttons after a short delay if pressed */
@@ -899,6 +905,12 @@ static struct sony_nc_event sony_100_events[] = {
{ 0x1f, SONYPI_EVENT_ANYBUTTON_RELEASED },
{ 0xa1, SONYPI_EVENT_MEDIA_PRESSED },
{ 0x21, SONYPI_EVENT_ANYBUTTON_RELEASED },
+ { 0xa4, SONYPI_EVENT_WEB_PRESSED },
+ { 0x24, SONYPI_EVENT_ANYBUTTON_RELEASED },
+ { 0xa5, SONYPI_EVENT_VAIO_PRESSED },
+ { 0x25, SONYPI_EVENT_ANYBUTTON_RELEASED },
+ { 0xa6, SONYPI_EVENT_ASSIST_PRESSED },
+ { 0x26, SONYPI_EVENT_ANYBUTTON_RELEASED },
{ 0, 0 },
};
diff --git a/include/linux/sonypi.h b/include/linux/sonypi.h
index 4f95c1a..55369d8 100644
--- a/include/linux/sonypi.h
+++ b/include/linux/sonypi.h
@@ -112,6 +112,9 @@
#define SONYPI_EVENT_VOLUME_DEC_PRESSED 70
#define SONYPI_EVENT_BRIGHTNESS_PRESSED 71
#define SONYPI_EVENT_MEDIA_PRESSED 72
+#define SONYPI_EVENT_ASSIST_PRESSED 73
+#define SONYPI_EVENT_WEB_PRESSED 74
+#define SONYPI_EVENT_VAIO_PRESSED 75
/* get/set brightness */
#define SONYPI_IOCGBRT _IOR('v', 0, __u8)
--
1.7.0.4
