Re: [PATCH 1/2] Make WMI be selected automatically when needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:

>  config LEDS_DELL_NETBOOKS
>  	tristate "External LED on Dell Business Netbooks"
> -	depends on X86 && ACPI_WMI
> +	depends on X86
> +	depends on ACPI
> +	select ACPI_WMI

I dislike this. The originally stated dependencies are correct and more 
accurately represent what the code requires, and changing that for the 
sake of making it easier for people to find the driver sounds like it's 
trying to cover up shortcomings in our configuration system more than 
anything else.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux