On Fri, Apr 9, 2010 at 7:46 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> Hi Yong,
>
> On Fri, Apr 09, 2010 at 11:06:52PM +0800, Yong Wang wrote:
>> +
>> +static void eeepc_wmi_input_exit(struct eeepc_wmi *eeepc_wmi)
>> +{
>> + if (eeepc_wmi->input_dev) {
>
> You abandon platform probe if input initialization fails, therefore you
> do not need to check for presence of input device on removal, right?
It's needed for patch 4/4, and anyway I think it's cleaner like that :).
>>
>> - wmi_set_driver_data(EEEPC_WMI_EVENT_GUID, eeepc_wmi);
>>
>> - err = eeepc_wmi_input_init(eeepc_wmi);
>> + eeepc_wmi->platform_dev = platform_device_alloc("eeepc-wmi", -1);
>> + if (!eeepc_wmi->platform_dev) {
>
> See if platform_create_bundle() will simplify things for you.
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
