Threads. Beginner question about how to use.

[Rodrigo Pimenta Carvalho <pimenta@xxxxxxxxx>]

Hi.

I'm implementing a softphone that must create a new thread when a function is invoked.

Such thread executes another very simple function. The simple function just prints a 'hello world' and nothing more.

When the simple function ends,  the entire softphone craches and 'die'. 

Could someone check the code (c++) bellow and tell me if I am doing something wrong please?

--------------------------------------------------------------------------------------------------------------------------------------

I created the thread:

        pj_caching_pool_init(&cp, NULL, 1024*1024 );

        pool = pj_pool_create(&cp.factory,                                   // the factory
                             "pool5",                                                             // pool's name
                              PJ_THREAD_DEFAULT_STACK_SIZE, // initial size
                              4000,                                                                // increment size
                              NULL);                                                           
        if (pool == NULL) {
            qDebug(" Pool error. \n");
        }
        else{
           pj_thread_create(pool, "MySimpleThread", (pj_thread_proc*)&:: sdCardWatchDog,
                            NULL,
                            PJ_THREAD_DEFAULT_STACK_SIZE,
                            0,
                            &newThread);
        }


The code of the simple function is:

static void * sdCardWatchDog(){
    qDebug(" Hello World !! \n");
    return NULL;
}

In  header file I have:

    pj_caching_pool cp;
    pj_thread_t * newThread;
    pj_pool_t *pool;
    static void * sdCardWatchDog();

Any hint will very helpful!

Best regards.

RODRIGO PIMENTA CARVALHO
Inatel Competence Center
Software
Ph: +55 35 3471 9200 RAMAL 979

---

De: pjsip <pjsip-bounces@xxxxxxxxxxxxxxx> em nome de Ming <ming@xxxxxxxxx>
Enviado: sexta-feira, 10 de novembro de 2017 08:04
Para: pjsip list
Assunto: Re: Stack-buffer overflow in pjsip_multipart_parse and pj_scan_get_quotes

 

Hi Stephan,

Ah, silly me. Forgot to include the flags when compiling PJSIP.

Thanks for letting me know. I've found the problems and fixed them, all three programs you sent coughed up no errors now. Currently still checking for the same patterns in other places as well. Will update you when it's done, probably early next week.

Thanks a lot and have a good weekend.

Regards,

Ming

On Fri, Nov 10, 2017 at 4:48 PM, Stephan Zeisberg <stephan@xxxxxxxxx> wrote:

Hi Ming —

Please try the following to reproduce the issues:

$ ./configure CFLAGS='-fsanitize=address -fno-omit-frame-pointer' LDFLAGS='-fsanitize=address -fno-omit-frame-pointer'

$ clang -o out multipart-parse-overflow.c -O1 -g -fsanitize=address -fno-omit-frame-pointer pjsip/lib/libpjsip-x86_64-unknown-linux-gnu.a pjlib-util/lib/libpjlib-util-x86_64-unknown-linux-gnu.a pjlib/lib/libpj-x86_64-unknown-linux-gnu.a -Ipjlib/include/ -Ipjlib-util/include/ -Ipjsip/include -lpthread -lm -luuid

$ ./out

I've attached the AddressSanitizer output for the three issues.

Best

    -Stephan

On 11/10/2017 02:05 AM, Ming wrote:
> Hi Stephan,
>
> Thanks for the report.
>
> I ran all three programs under AddressSanitizer (https://github.com/google/sanitizers/wiki/AddressSanitizer) and it didn't report any warning or error at all.
>
> Command I used (on Mac):
> clang -fsanitize=address -O1 -fno-omit-frame-pointer -g -o out pj-scan-get-until-ch-overflow.c pjsip/lib/libpjsip-x86_64-apple-darwin16.7.0.a pjlib-util/lib/libpjlib-util-x86_64-apple-darwin16.7.0.a pjlib/lib/libpj-x86_64-apple-darwin16.7.0.a -Ipjlib/include/ -Ipjlib-util/include/ -Ipjsip/include -lpthread -lm
>
> && ./out
>
> The valgrind reports you attached do not seem to point to any stack overflow either (or perhaps it could be me that don't know how to read it). So if you have additional details (such as which packet bytes trigger the issue, or better yet, which particular PJSIP code is the problematic one, or even better yet, how to fix it :) ), please share them with us.
>
> Regards,
> Ming
>
> On Fri, Nov 10, 2017 at 12:14 AM, Stephan Zeisberg <stephan@xxxxxxxxx <mailto:stephan@xxxxxxxxx>> wrote:
>
>     Dear all —
>
>     Please find attached two sample programs that parse a SIP message using pjsip_parse_msg. Both programs cause a stack-buffer overflow.
>
>     # Version
>
>     trunk
>
>     # How to reproduce pjsip_multipart_parse overflow:
>
>     $ clang -o out multipart-parse-overflow.c pjsip/lib/libpjsip-x86_64-unknown-linux-gnu.a pjlib-util/lib/libpjlib-util-x86_64-unknown-linux-gnu.a pjlib/lib/libpj-x86_64-unknown-linux-gnu.a -Ipjlib/include/ -Ipjlib-util/include/ -Ipjsip/include -lpthread -lm -luuid
>
>     $ valgrind ./out
>
>     The resulting valgrind output is attached.
>
>     # How to reproduce pj_scan_get_quotes overflow:
>
>     $ clang -o out pj-scan-get-quotes-overflow.c pjsip/lib/libpjsip-x86_64-unknown-linux-gnu.a pjlib-util/lib/libpjlib-util-x86_64-unknown-linux-gnu.a pjlib/lib/libpj-x86_64-unknown-linux-gnu.a -Ipjlib/include/ -Ipjlib-util/include/ -Ipjsip/include -lpthread -lm -luuid
>
>     $ valgrind ./out
>
>     The resulting valgrind output is attached.
>
>     The issues have been found with afl-fuzz in ASAN mode.
>
>     Cheers
>
>         -Stephan Zeisberg
>
>
>     _______________________________________________
>     Visit our blog: http://blog.pjsip.org
>
>     pjsip mailing list
>     pjsip@xxxxxxxxxxxxxxx <mailto:pjsip@xxxxxxxxxxxxxxx>
>     http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org <http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org>

>
>
>
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip@xxxxxxxxxxxxxxx
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

_______________________________________________
Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@xxxxxxxxxxxxxxx
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

_______________________________________________
Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@xxxxxxxxxxxxxxx
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org