Re: [PATCH] [pjmedia-codec] Fix pjmedia_codec_ilbc_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kal,

You're right of course. Added this in r5674
(https://trac.pjsip.org/repos/changeset/5674).

On Mon, Oct 16, 2017 at 6:11 PM, b17 c0de <b17c0de@xxxxxxxxx> wrote:
> Hi Ming,
> Thanks for the fast response. I looked at your changes. They look
> good, except, don't we also need to reset ilbc_factory.endpt at the
> end of deinit()?
>
> ....
>
> ilbc_factory.endpt = NULL;
> return status.
>
> Kal
>
> On Mon, Oct 16, 2017 at 5:50 AM, Ming <ming@xxxxxxxxx> wrote:
>> Hi Kal,
>>
>> Thanks for the patch. I fixed the deinit() as well and committed this
>> in r5673 (https://trac.pjsip.org/repos/changeset/5673).
>>
>> Regards,
>> Ming
>>
>> On Fri, Oct 13, 2017 at 6:52 PM, b17 c0de <b17c0de@xxxxxxxxx> wrote:
>>> Hi,
>>> pjmedia_codec_ilbc_init() is broken. If it is successfully called
>>> twice, very bad things happen. I have attached a patch to fix the
>>> issue.
>>>
>>> Kal
>>>
>>> _______________________________________________
>>> Visit our blog: http://blog.pjsip.org
>>>
>>> pjsip mailing list
>>> pjsip@xxxxxxxxxxxxxxx
>>> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>>>
>>
>> _______________________________________________
>> Visit our blog: http://blog.pjsip.org
>>
>> pjsip mailing list
>> pjsip@xxxxxxxxxxxxxxx
>> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip@xxxxxxxxxxxxxxx
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org

_______________________________________________
Visit our blog: http://blog.pjsip.org

pjsip mailing list
pjsip@xxxxxxxxxxxxxxx
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org



[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux