Hello,
I was updating my project to the latest trunk version and I noticed a potential reference counting issue in the changes made in r4661.
In both the sip_transport_tcp.c and sip_transport_tls.c the new change potentially leaves an added reference in second check added (with the check again comment). A reference was added to the transport that is never decremented.
Should this:
/* check again */
if (tcp->base.is_shutdown || tcp->base.is_destroying)
return;
be changed to this:
/* check again */
if (tcp->base.is_shutdown || tcp->base.is_destroying) {
pjsip_transport_dec_ref(&tcp->base);
return;
}
or am I missing something?
Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20131205/f2c78ab2/attachment-0001.html>
