Two bugs in inv_respond_incoming_update: 1. A comment says "Send 500 with Retry-After header set randomly between 0 and 10 if we receive UPDATE while we haven't sent answer." ?This doesn't actually happen, though; there's no provision for setting a Retry-After in the following code. 2. I think the "If UPDATE doesn't contain SDP" test should be checked before the "Send 500 if" test. ?I ran into a problem where: Phone A calls Phone B Phone B starts an assisted transfer call to phone C (pjsip) While phone C is ringing, Phone B hits the transfer again to make it into a blind transfer. Asterisk sends an UPDATE to phone C containing new caller id information (P-Asserted-Identity IIRC). Phone C sends a 500 response, and asterisk gives up on phone C. The "Send 500 if" test only makes sense in an SDP negotiation situation, so it should be after the if-no-sdp. ? Fixing the missing Retry-After header may or may not solve this particular situation, depending how asterisk works. ?But I think swapping the order and also adding the retry is the right thing. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20121101/2e05303e/attachment-0001.html>
