When parsing pidf bodies, pjsip 1.10 crashes if it encounters a <tuple> node without a <basic> under <status>.? As I read RFC3863, section 4.1.3, the <basic> node is OPTIONAL, and so this is out of spec.
I propose this patch as a fix, but it's possible I'm missing something.? If so, please enlighten me.
Index: pjsip/src/pjsip-simple/pidf.c
===================================================================
--- pjsip/src/pjsip-simple/pidf.c??? (revision 38299)
+++ pjsip/src/pjsip-simple/pidf.c??? (working copy)
@@ -324,7 +324,8 @@
?PJ_DEF(pj_bool_t) pjpidf_status_is_basic_open(const pjpidf_status *st)
?{
???? pj_xml_node *node = pj_xml_find_node((pj_xml_node*)st, &BASIC);
-??? pj_assert(node != NULL);
+??? if (node == NULL)
+??????? return PJ_FALSE ;
???? return pj_stricmp(&node->content, &OPEN)==0;
?}
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20110908/55d7d59c/attachment.html>
