On Wed, Nov 11, 2009 at 3:07 AM, Robbie Hanson <robbiehanson at deusty.com> wrote: > The documentation for pjsua_config.max_calls says this: > > Maximum calls to support (default: 4). The value specified here must be > smaller than the compile time maximum settings PJSUA_MAX_CALLS, which by > default is 32. To increase this limit, the library must be recompiled with > new PJSUA_MAX_CALLS value. > > However, the library doesn't do any checking to ensure that max_calls <= > PJSUA_MAX_CALLS. ?It probably should, as this will result in a crash at a > later time when using the library. > For example, say PJSUA_MAX_CALLS is set to 4, and max_calls is set to 8. > ?Then on the 5th call one makes, the library will crash. > I would suggest setting max_calls to the MIN of PJSUA_MAX_CALLS and the > requested max_calls. ?This could be done in maybe?pjsua_config_dup or > perhaps in?pjsua_call_subsys_init. Fixed. Done just like above. Thanks! Benny > -Robbie Hanson
