On 07/07/2008 23:40, Benny Prijono wrote: >> ... >> >> I mean, is it ok to remove the loopback-address check from >> ip_helper_generic.c:if_enum_by_af()? >> > > One of the negative impact of this is it will add loopback address to ICE > candidates, which is useless. But I've made some changes in r2112. There is Right, I didn't care about it! :) > now PJ_IP_HELPER_IGNORE_LOOPBACK_IF setting in pj/config.h, and default > value is one which means by default pjlib will ignore loopback interfaces. I > also made changes in proxy.h, to include the loopback address if > PJ_IP_HELPER_IGNORE_LOOPBACK_IF is set (in other words, loopback address > should always be added to proxy's aliases). Yeah, great! Thanks. >> ... >> >> This is already implemented. I only suggest that you >> developers (Benny?) comment out that (I'm trying to prove :) ) >> useless loopback check. >> > > Yes the enum_ip_interface() will only return the interfaces that have the > requested address family, so that's not a problem. The loopback check was > there because most usages (apart from proxy.h, apparently) don't need it. Right! Thank you so much! Best regards. PS: Have you ever heard about Git (git.or.cz)? It's far better than svn/cvs! :) -- Filippo Zangheri GPG key ID: 0x6C1F2F2F -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: OpenPGP digital signature Url : http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20080708/93c93c36/attachment.bin
