Callback not called when publishc authentication fails (commented out code?)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01 Jul 2008, at 21:15, Benny Prijono wrote:

> On Tue, Jul 1, 2008 at 5:46 PM, Ruud Klaver <ruud at ag-projects.com>  
> wrote:
>> Hi,
>>
>> I noticed that my publishc callback was not called when  
>> authentication
>> eventually fails. In publishc.c I found the following:
>>
>> 486             // Callback should have been called.
>> 487             // Calling it here will crash the system since pubc  
>> might
>> have been
>> 488             // destroyed
>> 489             //
>> 490             //if (status != PJ_SUCCESS) {
>> 491             //    call_callback(pubc, status, tsx->status_code,
>> 492             //                &rdata->msg_info.msg- 
>> >line.status.reason,
>> 493             //                rdata, -1);
>> 494             //}
>>
>> Is this still accurate? As far as I can see the _delete_flag should
>> guard against this sort of thing.
>>
>
> Yeah probably it does. But that doesn't protect it against callback
> being called more than once. I have alternative solution though, I've
> just checked that in in http://trac.pjsip.org/repos/ticket/553,
> hopefully that fixes it.
>
> Thanks for the report.
>
> -benny
>

You are a quick man, benny! Thanks a lot for the update.

Ruud Klaver
AG Projects



[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux