Hi ! Thank you very much for the commit. Best regards, Electrocut Benny Prijono wrote: > Just committed the patch in r1934. Sorry for the delay! > > Cheers > Benny > > On Mon, Apr 14, 2008 at 11:25 AM, Nanang Izzuddin <nanang at pjsip.org> wrote: > >> Hi, >> >> Ah sorry, stupid mistake, added one more patch for that: >> https://trac.pjsip.org/repos/ticket/526 >> >> nanang >> >> >> >> >> On 14/04/2008, Tanguy Floc'h <electrocut at gmail.com> wrote: >> > Hi ! >> > Thanks for having committed the changes. >> > >> > I think there is still a small problem in wav_player.c, when coming back >> > from the callback: >> > line 509, there is still an access to fport structure (which has just been >> > destroyed by pjsua_player_destroy(wavId); ), so I still have a crashing >> > problem in this case. >> > >> > line 509 in wav_player.c : >> > >> > if ((status != PJ_SUCCESS) || ( >>> fport <<< ->options & >> > PJMEDIA_FILE_NO_LOOP)) { >> > PJ_LOG(5,(THIS_FILE, "File port %.*s EOF, stopping..", >> > (int) >>> fport<<< ->base.info.name.slen, >> > >>> fport<<<< ->base.info.name.ptr)); >> > ... >> > } >> > >> > I've tried to store in a pj_bool_t variable the "looping" option before >> > calling the callback (loop = fport->options & PJMEDIA_FILE_NO_LOOP;) >> > >> > to use this value for the test, and to remove the logging line (which tries >> > to access fport structure too), and everything is ok now: >> > >> > if ((status != PJ_SUCCESS) || loop) { >> > /*PJ_LOG(5,(THIS_FILE, "File port %.*s EOF, stopping..", >> > (int)fport->base.info.name.slen, >> > fport->base.info.name.ptr));*/ >> > ... >> > return PJ_EEOF; >> > >> > } >> > >> > On Mon, Apr 14, 2008 at 5:13 AM, Benny Prijono <bennylp at pjsip.org> wrote: >> > >> > > >> > > On Sat, Apr 12, 2008 at 7:05 AM, Tanguy Floc'h <electrocut at gmail.com> >> > wrote: >> > > > >> > > > Thanks for having taken this problem into account so fast ! >> > > > I'll check that everything is ok now. >> > > > >> > > >> > > FYI I've just committed and closed the ticket. >> > > >> > > Thanks >> > > Benny >> > > >> > > >> > > >> > > >> > > _______________________________________________ >> > > Visit our blog: http://blog.pjsip.org >> > > >> > > pjsip mailing list >> > > pjsip at lists.pjsip.org >> > > >> > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >> > > >> > >> > >> > _______________________________________________ >> > Visit our blog: http://blog.pjsip.org >> > >> > pjsip mailing list >> > pjsip at lists.pjsip.org >> > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >> > >> > >> >> _______________________________________________ >> Visit our blog: http://blog.pjsip.org >> >> pjsip mailing list >> pjsip at lists.pjsip.org >> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org >> >> > > _______________________________________________ > Visit our blog: http://blog.pjsip.org > > pjsip mailing list > pjsip at lists.pjsip.org > http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20080419/ebeece89/attachment.html
