Can you access the other POST variables, if not put quotation marks around method="post", also try using instead of op something else... Kind Regards Arné Klopper ------------------------------------ NetCB Solutions (Pty) Ltd. www.netcb.com Office: +27 12 997 3007 Fax: 27 12 997 3629 Mobile: +27 84 513 4119 >>> <Remember14a@xxxxxxx> 2004/08/31 09:58:39 AM >>> Dear Friends, I have a reply form which writes to database, however it gives an error posted below. Guidance, please. ------------------------------------------------------------------------------ --- Error when I keep op like 'op' ------------------------------------------------------------------------------ - Notice: Undefined index: op in \\premfs15\sites\pre15\mrbupeace\webroot\replytopost.php on line 7 ---------------------------------------------------------------------------- error when I keep op like op without inverted comma's gives two different errors ------------------------------------------------------------------------------ ---- Notice: Use of undefined constant op - assumed 'op' in \\premfs15\sites\pre15\mrbupeace\webroot\replpost.php on line 7 Notice: Undefined index: op in \\premfs15\sites\premium15\mrbushforpeace\webroot\replytopost.php on line 7 ------------------------------------------------------------------------------ ---------- Code of the script ------------------------------------------------------------- <?php //connect to server and select database; we'll need it soon $conn = mysql_connect("orf-kster.com", "mr", "p") or die(mysql_error()); mysql_select_db("mr",$conn) or die(mysql_error()); //check to see if we're showing the form or adding the post if ($_POST['op'] != "addpost") { // showing the form; check for required item in query string if (!$_GET['post_id']) { header("Location: topiclist.php"); exit; } //still have to verify topic and post $verify = "select ft.topic_id, ft.topic_title from forum_posts as fp left join forum_topics as ft on fp.topic_id = ft.topic_id where fp.post_id = $_GET[post_id]"; $verify_res = mysql_query($verify, $conn) or die(mysql_error()); if (mysql_num_rows($verify_res) < 1) { //this post or topic does not exist header("Location: topiclist.php"); exit; } else { //get the topic id and title $topic_id = mysql_result($verify_res,0,'topic_id'); $topic_title = stripslashes(mysql_result($verify_res, 0,'topic_title')); print " <html> <head> <title>Post Your Reply in $topic_title</title> </head> <body> <h1>Post Your Reply in $topic_title</h1> <form method=post action=\"$_SERVER[PHP_SELF]\"> <p><strong>Your E-Mail Address:</strong><br> <input type=\"text\" name=\"post_owner\" size=40 maxlength=150> <P><strong>Post Text:</strong><br> <textarea name=\"post_text\" rows=8 cols=40 wrap=virtual></textarea> <input type=\"hidden\" name=\"op\" value=\"addpost\"> <input type=\"hidden\" name=\"topic_id\" value=\"$topic_id\"> <P><input type=\"submit\" name=\"submit\" value=\"Add Post\"></p> </form> </body> </html>"; } } else if ($_POST[op] == "addpost") { //check for required items from form if ((!$_POST['topic_id']) || (!$_POST['post_text']) || (!$_POST['post_owner'])) { header("Location: topiclist.php"); exit; } //add the post $add_post = "insert into forum_posts values ('', '$_POST[topic_id]', '$_POST[post_text]', now(), '$_POST[post_owner]')"; mysql_query($add_post,$conn) or die(mysql_error()); //redirect user to topic exit; } ?>