On June 26, 2020 12:05:29 PM UTC, Kevin Waterson <kevin.waterson@xxxxxxxxx> wrote: >It's an example you dick, but production code. >Chill the fuck out > >On Fri, 26 Jun 2020, 2:23 pm Ashley Sheridan, ><ash@xxxxxxxxxxxxxxxxxxxx> >wrote >> >> That would end up blocking literally millions of valid names. Even if >you >> assume that names will all originate from a specific country (so we >don't >> have to deal with CJK, Cyrillic, or less common diacritics) you still >have >> to deal with hyphens, apostrophes, and common diacritics. So names >like >> Zöe, O'Reilly, Jean-Paul, André, would all be considered invalid by >your >> code example. >> >https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ >> lists a ton of other things to be careful about blocking. >> >> It's also worth pointing out that you're doing validation rather than >> sanitisation. These are different and aren't interchangeable. >> Thanks, >> Ash >> I really don't appreciate that kind of language, and I don't think anyone on this list should be expected to. Thanks, Ash
