I disagree with you Ashley, some arguments can be found here: http://sqlblog.com/blogs/aaron_bertrand/archive/2009/10/10/bad-habits-to-kick-using-select-omitting-the-column-list.aspx Using explicit columns names in the select clause is, IMHO, at least a good documentation for what is being requested to the database layer. +1 to Maciek's suggestion, had totally forgotten this one. Cheers. -----Mensagem original----- De: Ashley Sheridan [mailto:ash@xxxxxxxxxxxxxxxxxxxx] Enviada em: sábado, 22 de setembro de 2012 11:52 Para: Samuel Lopes Grigolato; 'PHP List' Assunto: Re: RES: Re: Need help to understand a code Samuel Lopes Grigolato <samuel.grigolato@xxxxxxxxx> wrote: >+1 to bad maintainability of the code. > >As a suggestion, one better solution could be something like: > >[...] > >class Entity { > public $id; > public $name; >} > >[...] > >$entity = new Entity(); >foreach [...] > $entity->$$key = $value; > >[...] > >And, of course, never ever use "*" in SQL queries. > >Samuel. > >-----Mensagem original----- >De: Matijn Woudt [mailto:tijnema@xxxxxxxxx] Enviada em: sábado, 22 de >setembro de 2012 11:02 >Para: ash@xxxxxxxxxxxxxxxxxxxx >Cc: Ashickur Rahman Noor; PHP List >Assunto: Re: Re: Need help to understand a code > >Op 22 sep. 2012 13:47 schreef "Ashley Sheridan" ><ash@xxxxxxxxxxxxxxxxxxxx> het volgende: >> >> On Sat, 2012-09-22 at 17:43 +0600, Ashickur Rahman Noor wrote: >> >> > Hi Ashley >> > >> > I am updating some one code. Thanks for the notify. >> > >> > Thanks to all. Now I get that. >> > ---------------------------------------------------------- >> > Dedicated Linux Forum in Bangladesh <http://goo.gl/238Ck> >> > 2048R/89C932E1 <http://goo.gl/TkP5U> Coordinator - Public Relation >> > Cell, FOSS Bangladesh <http://fossbd.org/> && Mozilla Reps >> > <http://reps.mozilla.org> 01199151550, 01551151550 >> >> >> It's probably fine doing that for your example, as the content coming > >> from the database will be content you expect, but be wary of using it > >> on any of the user-generated arrays like $_GET, or $_POST. >> > >And a few months/years later you decide to add a new column to your db >which has the same name as one of the variables you're already using >and the script starts acting very strange... >People should stop using bad coding habits like these.. > >- Matijn > > >-- >PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: >http://www.php.net/unsub.php there's nothing wrong with using * in queries. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. -- PHP General Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
