Hello, Good points. If you are getting paid to do that then fine. There is a difference between enhancing code and wasting time. I do my best to come up with the best I can. I always take notes to perform better in upcoming projects. It is imperative to make good use of time. Unless it is a security issue, no need to waste time. Again, if you are getting paid for it then fine. People tune cars for a reason, they want the attention or the thrill. If you want to tune your code for fun then nobody is against that either :) Ravi. On Tue, Dec 21, 2010 at 1:28 PM, ash@xxxxxxxxxxxxxxxxxxxx < ash@xxxxxxxxxxxxxxxxxxxx> wrote: > (Apologies for top posting; on my mobile just now.) > > Not true. Refactoring code is one of the main tasks of a developer. None of > us produce perfect code, and some code is less perfect than other code. It's > instinct to want to fix bad code when we're maintaining it or having to add > new features to it. > > For the same reason car enthusiasts tinker with and tune their cars, good > developers will do the same with code, be it in the form of consolidating > common code to include files or other ways. To not do so seems to me to > avoid ones nature really! > > Thanks, > Ash > http://www.ashleysheridan.co.uk > > ----- Reply message ----- > From: "Ravi Gehlot" <ravi@xxxxxxxxxxxxxx> > Date: Tue, Dec 21, 2010 18:12 > Subject: Problem with Include > To: "Paul M Foster" <paulf@xxxxxxxxxxxxxxxxx> > Cc: <php-general@xxxxxxxxxxxxx> > > > If something is working and you don't know exactly whats under the hood > then > you are wasting your time in trying to re-invent your own wheel and waste > your time and resources to modify something that isn't needed to be > touched. > Good programmers make good use of their time as well. We need to keep in > check with new technology, learn new trends and also master our weakness. > If > we keep changing this or that or moving that or this then oh well...there > goes 1 day worth of work to figure stuff out. > > Just my take on this. If you think different, then no problems. > > Regards, > Ravi. > > > On Tue, Dec 21, 2010 at 10:23 AM, Paul M Foster <paulf@xxxxxxxxxxxxxxxxx > >wrote: > > > On Tue, Dec 21, 2010 at 02:35:33AM -0500, David Hutto wrote: > > > > > On Tue, Dec 21, 2010 at 2:29 AM, Ravi Gehlot <ravi@xxxxxxxxxxxxxx> > > wrote: > > > > Why mess with something that is already working? If you are trying to > > make > > > > it pretty then you are not solving a problem. You are creating one. > > > > > > > > > Define working. I've had programs 'work', but more experienced would > > > say it's flawed in some respect. Does it perform the immediate task? > > > > > > Now define pretty. Is it aesthetically pleasing to you, or to someone > > > else with less, or maybe more experience. > > > > > > By defining the two above, you then define whether it's a problem. To > > > you, or to them, or to the original designer? > > > > Beware of "more experienced" programmers. I recently talked to an > > ex-boss of mine who had a programmer flake out on him. One of his > > customers threatened to take this flaky code to another company and get > > their opinion about whether it was good code or not. My ex-boss > > explained that, of course, they'd shoot it down. Because that's what > > programmers do-- they complain about other programmers' code. I'd never > > heard that idea expressed aloud. But when I thought about it, I realized > > it was true. Hell, look at the content of this list. ;-} > > > > Paul > > > > -- > > Paul M. Foster > > > > -- > > PHP General Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > >