Re: How to get a code review?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 3, 2008 at 10:41 AM, David Jourard <davidj@xxxxxxxxxxxxxxxxxxxx>
wrote:

> Nathan Nobbe wrote:
>
> > how much code is there ?
> >
> 200 lines


i think ur safe posting that on the list directly.  sometimes people post
several thousand lines and those sort of things are overlooked.

I work alone and this is basically my first program.
>

i drink alone ;)

I'm interested in feedback as to
>
> a. Am I using the variables correctly wrt global and local and passing by
> reference etc.
> b. Did I use the correct functions or are there better ones
> c. Security - of course
> d. Any suggestions on improving overall style.
>
> e. Is it ok to put the include file in the cgi-bin with my perl scripts.
>
> For many of you this is basic stuff probably but I want to make sure I'm
> getting it right.
>
> Note the login cookie is created by my perl script and the php program
> simply has to check that the user is logged in.


drop it in a post and well have a look.

-nathan

[Index of Archives]     [PHP Home]     [Apache Users]     [PHP on Windows]     [Kernel Newbies]     [PHP Install]     [PHP Classes]     [Pear]     [Postgresql]     [Postgresql PHP]     [PHP on Windows]     [PHP Database Programming]     [PHP SOAP]

  Powered by Linux