Re: Making thumbs same size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007. 06. 5, kedd keltezéssel 09.17-kor tedd ezt írta:
> At 9:56 AM -0400 6/4/07, Robert Cummings wrote:
> >On Mon, 2007-06-04 at 09:50 -0400, tedd wrote:
> >>
> >>  Don't scale, resample. See here:
> >>
> >>  http://www.webbytedd.com/b/thumb/index.php
> >
> >Hi Tedd,
> >
> >In your script you have:
> >
> >     ini_set( 'register_globals', '0' );
> >
> >The line is pointless, it can't be reached until after such globals have
> >been registered.
> >
> >Also you have:
> >
> >     ob_start();
> >
> >Why use output buffering? You don't actually do anything with the buffer
> >other than flushing it :)
> >
> >Cheers,
> >Rob.
> 
> Rob:
> 
> What?!
> 
> I didn't do that.  No one saw me do it and can't prove it. Besides, I 
> changed the code. :-)
> 
> My explanation, legacy remnants.
> 
> Cheers,
> 
> tedd
> 
> PS: It's always pays to have someone knowledgeable review your code -- thanks.

one more note:
you have ignore_user_abort(); in the beginning of the script, but
according to the manual ( http://php.net/ignore_user_abort ) it should
be used like ignore_user_abort(TRUE); otherwise it only returns the
current setting...

greets
Zoltán Németh

> -- 
> -------
> http://sperling.com  http://ancientstones.com  http://earthstones.com
> 

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


[Index of Archives]     [PHP Home]     [Apache Users]     [PHP on Windows]     [Kernel Newbies]     [PHP Install]     [PHP Classes]     [Pear]     [Postgresql]     [Postgresql PHP]     [PHP on Windows]     [PHP Database Programming]     [PHP SOAP]

  Powered by Linux