Re: Re: User error handler must not modify error context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2005-09-19 at 23:09, Jasper Bryant-Greene wrote:
> Noel wrote:
> > Actually, that's all of it aside from the function statement and the 
> > return statement.
> > 
> > function funcTitle ($title='') {
> >         global $mywebsite;
> >         if ($_POST['title']) $title = $_POST['title'];
> >         elseif ($_GET['title']) $title = $_GET['title'];
> >         elseif (!$title) $title = $mywebsite;
> >         return '<title>'.$title.'</title>';
> >         }
> > 
> > I don't see anything wrong with the code, do you? After all, the error 
> > does not occur if I try to comment out the user_error_handler() 
> > function. And also, this error didn't occur in the previous version. 
> > Nothing has been modified in the PHP codes when the PHP version has been 
> > upgraded to 4.4. Only after the upgrade did this error occurred.

Check your error reporting level. Your code above is sloppy since you
don't bother checking to see if the title entry exists in the $_POST or
$_GET arrays first.

function funcTitle( $title='' )
{
    global $mywebsite;

    if( isset( $_POST['title'] ) && $_POST['title'] )
    {
        $title = $_POST['title'];
    }
    else
    if( isset( $_GET['title'] ) && $_GET['title'] )
    {
        $title = $_GET['title'];
    }
    else
    if( !$title )
    {
        $title = $mywebsite;
    }

    return '<title>'.$title.'</title>';
}

Cheers,
Rob.
-- 
.------------------------------------------------------------.
| InterJinn Application Framework - http://www.interjinn.com |
:------------------------------------------------------------:
| An application and templating framework for PHP. Boasting  |
| a powerful, scalable system for accessing system services  |
| such as forms, properties, sessions, and caches. InterJinn |
| also provides an extremely flexible architecture for       |
| creating re-usable components quickly and easily.          |
`------------------------------------------------------------'

-- 
PHP General Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php


[Index of Archives]     [PHP Home]     [Apache Users]     [PHP on Windows]     [Kernel Newbies]     [PHP Install]     [PHP Classes]     [Pear]     [Postgresql]     [Postgresql PHP]     [PHP on Windows]     [PHP Database Programming]     [PHP SOAP]

  Powered by Linux