Search Postgresql Archives

Re: strange infinite loop in plpgsql

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



rihad <rihad@xxxxxxx> writes:
>      LOOP
>        SELECT date+1 INTO day FROM days WHERE date=day OR EXTRACT(dow 
> FROM day) IN (0,6);
>        EXIT WHEN NOT FOUND;
>        timeout := timeout + 86400;
>      END LOOP;

If the EXTRACT condition is true, then the SELECT will always succeed.
This code will get even more whacko once you have more than one row
in "days", because it'll pick a random one of the rows in that case
(in practice, the physically first one).  I think you need something
more like

	LOOP
	  IF EXTRACT(dow FROM day) IN (0,6) THEN
	    -- don't bother to consult table on weekends
	    day := day + 1;
	  ELSE
	    SELECT date+1 INTO day FROM days WHERE date=day;
	    EXIT WHEN NOT FOUND;
	  END IF;
	  timeout := timeout + 86400;
	END LOOP;

BTW, you forgot to initialize "timeout".

			regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Postgresql Jobs]     [Postgresql Admin]     [Postgresql Performance]     [Linux Clusters]     [PHP Home]     [PHP on Windows]     [Kernel Newbies]     [PHP Classes]     [PHP Books]     [PHP Databases]     [Postgresql & PHP]     [Yosemite]
  Powered by Linux