"Tom Lane" <tgl@xxxxxxxxxxxxx> writes: > Gregory Stark <stark@xxxxxxxxxxxxxxxx> writes: >> "Tom Lane" <tgl@xxxxxxxxxxxxx> writes: >>> There are a few old bits of code that still use MAKE_PTR/MAKE_OFFSET, >>> but I think it's mostly just that no one's bothered to rewrite the code >>> for SHM_QUEUE linked lists. The vast majority of our shmem structures >>> use regular pointers, and have for years. > >> Ah, I happened to be recently in that code so I was mislead. > > IIRC, the reason for not bothering to change the SHM_QUEUE code (other > than inertia) was that it's a generic linked list package, and so if > it wasn't storing SHMEM_OFFSETs it'd be storing "void *"'s, and so there > didn't seem to be any traction to be gained in terms of compiler error > detection capability. However, if both you and Alvaro were confused > about the liveness of that coding convention, maybe it'd be worth making > a push to eliminate all trace of MAKE_PTR/MAKE_OFFSET. TODO for 8.4? It would also make using gdb to look at the lock queues a bit less of a pain. -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to majordomo@xxxxxxxxxxxxxx so that your message can get through to the mailing list cleanly
