=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@xxxxxxxxxxxxxx> writes: > That said, we could add a comment that makes this more obvious: > ... > This looks a tad redundant in pg_type.h itself, but makes the generated > pg_type_d.h file more obvious: I think it's a mistake to suppose that pg_type_d.h is the only place where there's a risk of confusion. We should be thinking about this more generally: genbki.pl is taking zero thought to make what it emits readable. I think it would help to label the sections it emits, perhaps along the lines of /* Auto-generated OID macros */ for this part, and I'm not sure what other parts would be useful to label. As for CASHOID and LSNOID, surely those have been deprecated long enough that we could just remove them? regards, tom lane
