Re: plpgsql_check_function issue after upgrade

[shashidhar Reddy <shashidharreddy001@xxxxxxxxx>]

I have tried updating after upgrade but that wasn't  working, so I have dropped and recreated the extension.

Now it is crashing every time when we call the function. 

On Tue, 29 Nov, 2022, 9:58 pm Pavel Stehule, <pavel.stehule@xxxxxxxxx> wrote:

út 29. 11. 2022 v 16:37 odesílatel shashidhar Reddy <shashidharreddy001@xxxxxxxxx> napsal:

Plogsql check version is 2.2 and one more finding is before calling the function if we drop and recreate the plpgsql_check extension there is no issue, but each time we can't drop and create.

Maybe you need to run ALTER EXTENSION plpgsql_check UPDATE before first usage in pg 13

If the extension works after re-installation, then the problem is not in an extension.

On Tue, 29 Nov, 2022, 7:19 pm shashidhar Reddy, <shashidharreddy001@xxxxxxxxx> wrote:

Hello Pavel,

This is the function causing the issue on all servers, and also i noticed when I use plpgsql_check_function in any function I am facing the same issue.

On Tue, Nov 29, 2022 at 6:43 PM Pavel Stehule <pavel.stehule@xxxxxxxxx> wrote:

Hi

út 29. 11. 2022 v 13:49 odesílatel shashidhar Reddy <shashidharreddy001@xxxxxxxxx> napsal:

Hello,

Recently we have upgraded postgres from version 12 to 13 and upgraded  plpgsql_check to the latest version but after upgrade when calling the below function causing postgres restart .

CREATE OR REPLACE FUNCTION pro.po_check(
)
    RETURNS void
    LANGUAGE 'plpgsql'
    COST 100
    VOLATILE SECURITY DEFINER PARALLEL UNSAFE
AS $BODY$
DECLARE
BEGIN

    PERFORM p.oid, n.nspname, p.proname, plpgsql_check_function(p.oid)
    FROM pg_catalog.pg_namespace n
    JOIN pg_catalog.pg_proc p ON pronamespace = n.oid
    JOIN pg_catalog.pg_language l ON p.prolang = l.oid
    WHERE l.lanname = 'plpgsql' AND p.prorettype <> 2279
    and upper(n.nspname) like upper('Pro');

END;
$BODY$;

and the error in syslogs shows

kernel: [93631.415790] postgres[86383]: segfault at 80 ip 00007f07f3e3eefd sp 00007fffcf1db500 error 4 in plpgsql_check.so[7f07f3e2e000+34000]

it can be a bug in plpgsql_check. But I am not able to fix it without some information. Can you send the reproducer (minimal example of your code, that reproduce this error)?

Regards

Pavel

--

Shashidhar

--

Shashidhar