Search Postgresql Archives

Re: Calculating a moving average (Coding style)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



mstory@xxxxxxxxxxxx wrote:
CREATE OR REPLACE FUNCTION get_bar_avg() RETURNS TRIGGER AS '
DECLARE
bar_record RECORD;
x INTEGER;
y DOUBLE PRECISION := 0;
BEGIN
     IF TG_OP = ''INSERT'' THEN
          y := y + NEW.bar;
...
          RETURN NEW;
     ELSIF TG_OP = ''DELETE'' THEN
           x := 0;
...
           RETURN OLD;
      ELSE
           y := y + NEW.bar;
...
           RETURN NEW;
      END IF;
END;
' LANGUAGE plpgsql;

I see people do this from time to time. Just out of curiosity, is this considered good coding style, or is it considered "lazyness"? I'm not sure what to think of it.


If I would have written this, there would have been 3 triggers w/o the check on TG_OP. Is there an important drawback to doing so? Is there any document on "preferred" coding style in PL/PGSQL?

Yes, I'm a bit of a purist...

--
Regards,

Alban Hertroys
MAG Productions

T: +31(0)53 4346874
F: +31(0)53 4346876
E: alban@xxxxxxxxxxxxxxxxx
W: http://www.magproductions.nl

---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
   (send "unregister YourEmailAddressHere" to majordomo@xxxxxxxxxxxxxx)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Postgresql Jobs]     [Postgresql Admin]     [Postgresql Performance]     [Linux Clusters]     [PHP Home]     [PHP on Windows]     [Kernel Newbies]     [PHP Classes]     [PHP Books]     [PHP Databases]     [Postgresql & PHP]     [Yosemite]
  Powered by Linux