Thanks for fixing it.
Thanks,
Bhavesh
On Thu, Jul 29, 2021 at 12:49 PM Dave Cramer <davecramer@postgres.rocks> wrote:
On Thu, 29 Jul 2021 at 15:44, Bhavesh Mistry <bhavesh.mistry13@xxxxxxxxx> wrote:Hi Dave,It still does not address the NPE issue. If an alias is NULL. What should be the behavior?
public String getTypeForAlias(String alias) { String type = TYPE_ALIASES.get(alias); if (type != null) { return type; } type = TYPE_ALIASES.get(alias.toLowerCase()) // NPE STILL HERE; if (type == null) { type = alias; } //populate for future use TYPE_ALIASES.put(alias, type); return type; } Very good question. I guess we should return null in this case.I'll fix thatDave
Thanks,
Bhavesh