On Thu, Jul 2, 2020 at 11:44 PM Tom Lane <tgl@xxxxxxxxxxxxx> wrote:
Anders Steinlein <anders@xxxxxx> writes:
> I'm reading this correctly, would this be a "reason" to be more explicit
> when doing joins involving non-standard data types? I.e. would it be
> "safer" to do ON x1.email::citext == x2.email::citext instead of USING (if
> there is any difference at all...)?
Yes, it would be. Of course then you don't get the "merging" of the two
join output columns into one, so you might have to qualify references a
bit more.
You might find this thread interesting:
https://www.postgresql.org/message-id/flat/ffefc172-a487-aa87-a0e7-472bf29735c8%40gmail.com
Indeed interesting, thanks!
Am I right in thinking that we should actually go over (i.e. re-create) all functions and views defined before this dump/restore where we're using JOIN ... USING (citext_column)? We most definitely have many more such cases, since this is the common (perhaps naive) way we've written joins (unless there are obvious reasons to be explicit). :-/
Best,
-- a.
