On February 15, 2019 9:44:50 AM PST, Tom Lane <tgl@xxxxxxxxxxxxx> wrote: >Andres Freund <andres@xxxxxxxxxxx> writes: >> On February 15, 2019 9:13:10 AM PST, Tom Lane <tgl@xxxxxxxxxxxxx> >wrote: >>> I'm of the opinion that we shouldn't be panicking for >sync_file_range >>> failure, period. > >> With some flags it's strictly required, it does"eat"errors depending >on the flags. So I'm not sure I understand? > >Really? The specification says that it starts I/O, not that it waits >around for any to finish. That depends on the flags you pass in. By memory I don't think it eats an error with our flags in recent kernels, but I'm not sure. Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity.