Thomas Munro <thomas.munro@xxxxxxxxxxxxxxxx> writes: >> On Fri, Feb 15, 2019 at 2:56 PM Bruce Klein <brucek@xxxxxxxxx> wrote: >>> In 11.1 did you see the message "WARNING: could not flush dirty data: Function not implemented" >> Yes > Here is a place where people go to complain about that: > https://github.com/Microsoft/WSL/issues/645 > I suppose we could tolerate ENOSYS. What I'm not grasping here is why you considered that sync_file_range failure should be treated as a reason to PANIC in the first place? Surely it is not fsync(), nor some facsimile thereof. In fact, if any of the branches in pg_flush_data really need the data_sync_elevel treatment, somebody's mental model of that operation needs adjustment. Maybe it's mine. regards, tom lane
