Search Postgresql Archives

Re: pgxs/config/missing is... missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/29/15 5:31 PM, David E. Wheeler wrote:
>even after explicitly exporting PERL=/usr/local/bin/perl
Hrm. I have this code in the pgTAP Makefile:

     ifndef PERL
     PERL := $(shell which perl)
     endif

Could that be causing the problem?

That doesn't help because PGXS defines PERL:

# Perl

ifneq (,)
    # quoted to protect pathname with spaces
    PERL                = ''
else
    PERL                = $(missing) perl
endif

On a system where configure could find perl, that first line is:

ifneq (/opt/local/bin/perl,)

So instead of checking ifndef, I'm thinking it should check ifeq($PERL,).

>I see that there is a config/missing script in source, and that Makefile.global.in references it:
>
>>src/Makefile.global.in:missing            = $(SHELL) $(top_srcdir)/config/missing
>
>Any ideas why it's not being installed, or why the PGXS Makefile is ignoring/over-riding $PERL?
That I surely don’t know.:-(

I'm not sure if this is the right way to go about it, but this patch at least installs the file.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
diff --git a/config/Makefile b/config/Makefile
index da12838..67e7998 100644
--- a/config/Makefile
+++ b/config/Makefile
@@ -7,9 +7,11 @@ include $(top_builddir)/src/Makefile.global
 
 install: all installdirs
 	$(INSTALL_SCRIPT) $(srcdir)/install-sh '$(DESTDIR)$(pgxsdir)/config/install-sh'
+	$(INSTALL_SCRIPT) $(srcdir)/missing '$(DESTDIR)$(pgxsdir)/config/missing'
 
 installdirs:
 	$(MKDIR_P) '$(DESTDIR)$(pgxsdir)/config'
 
 uninstall:
 	rm -f '$(DESTDIR)$(pgxsdir)/config/install-sh'
+	rm -f '$(DESTDIR)$(pgxsdir)/config/missing'
-- 
Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Postgresql Jobs]     [Postgresql Admin]     [Postgresql Performance]     [Linux Clusters]     [PHP Home]     [PHP on Windows]     [Kernel Newbies]     [PHP Classes]     [PHP Books]     [PHP Databases]     [Postgresql & PHP]     [Yosemite]
  Powered by Linux