Chris Angelico <rosuav@xxxxxxxxx> writes: > Point of random curiosity: The commit mentioned adds the following line: > if (rinfo->reloptions && strlen(rinfo->reloptions) > 0) > Is there a reason this isn't done as: > if (rinfo->reloptions && *rinfo->reloptions) Just that the former is the general coding style in pg_dump, not the latter. pg_dump typically isn't working with long strings in these places, so I'd be pretty surprised if this was a worthwhile optimization. But if we were going to do it we should do it throughout pg_dump, not just here. regards, tom lane -- Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-general
