Hi, On 5 November 2012 08:39, Chris Angelico <rosuav@xxxxxxxxx> wrote: > On Sat, Nov 3, 2012 at 9:15 AM, Joe Van Dyk <joe@xxxxxxxxx> wrote: > Point of random curiosity: The commit mentioned adds the following line: > > if (rinfo->reloptions && strlen(rinfo->reloptions) > 0) > > Is there a reason this isn't done as: > > if (rinfo->reloptions && *rinfo->reloptions) > > ? It seems like overkill to ascertain the string length just to find > out if the first character is the null terminator. My guess is to be multibyte encoding safe: UTF-16 or similar. -- Ondrej Ivanic (ondrej.ivanic@xxxxxxxxx) -- Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-general