On Sat, Feb 19, 2011 at 11:31 PM, Brar Piening <brar@xxxxxx> wrote:
On Thu, 17 Feb 2011 07:58:46 -0800 (PST), Ahmed <ahmed.shinwari@xxxxxxxxx> wrote:Yes, as SSPI uses binary bytes we have to avoid to convert them to characters and back to bytes during message generation.
I tried changing that one line to use UTF-8 encoder, but the password packet
didn't get fixed. It works smoothly if kept in byte array instead of string.
While "char *buffer" in C can serve as both a string and a buffer of binary bytes, we have "byte[]" as binary buffer and "string" as string in c#.
This is the reason why we need to use byte[] in all places where libpq uses char* without really caring whether there is a string inside or some opaque bytes.If this isn't necessary to fix the problem we should probably get some more instight to what really happens here before fixing one end and breaking the other.
I think changing the AuthenticationSSPI case to use context.Host may break
the cases Brar's mentioned.
I agree.
For now, Francisco may check in that part which fixes the bug due to encoding. And, address the later issue after further investigation.
For now, Francisco may check in that part which fixes the bug due to encoding. And, address the later issue after further investigation.
Regards,
Brar
