Hi Thom, Sorry for the delay, I got sick in the meantime. I see that others already did some review, I will do a quick one too, later maybe I'll actually try it out... so after a quick review: * on line 218, the " ENCODING '$DBname')" part feels wrong, you probably want hardcoded UTF8 encoding there ? * as Merlin already commented, transactions are always safe in postgres, this is no mysql ;-) * again, as Merlin commented, getTableList is getting the data bases, which doesn't make sense, but maybe you actually wanted to get the tables - in this case you don't have a typo but you need to change the query ;-) If I'll get some time I'll test it too, but likely not this week... Cheers, Csaba. On Tue, 2009-10-20 at 15:28 +0200, Thom Brown wrote: > 2009/10/20 Reid Thompson <reid.thompson@xxxxxxxx>: > > your attachment contains this... > > > > <?xml version="1.0" encoding="iso-8859-1"?> > > <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" > > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> > > <html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en"> > > <head> > > <title>403 - Forbidden</title> > > </head> > > <body> > > <h1>403 - Forbidden</h1> > > </body> > > </html> > > > > Erk.. that's weird. I got that too even after being logged in. I'm > not sure how anyone can review it if no-one has access to it. > > I've attached my working version which differs only slightly to > conform with coding-styles required by Joomla. > > Apologies > > Thom -- Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-general
